Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_calyptia_fleet: get __mkdir to work on non-Unix operating systems. #7969

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Sep 25, 2023

Summary

I refactored the __mkdir helper function to use PATH_SEPARATOR instead of the hardcoded '/' (Unix slash). This will allow it to work on win32.

This function is used to create the directory and sub directories where fleet configuration files are stored and then loaded.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.


@pwhelan pwhelan requested a review from edsiper September 25, 2023 15:33
@pwhelan pwhelan temporarily deployed to pr September 25, 2023 15:33 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 25, 2023 15:33 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 25, 2023 15:33 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 25, 2023 16:04 — with GitHub Actions Inactive
@pwhelan pwhelan added this to the Fluent Bit v2.1.11 milestone Sep 27, 2023
@pwhelan pwhelan force-pushed the pwhelan-fleet-windows-mkdir branch from cf241ff to 92c2cd0 Compare October 4, 2023 13:24
@pwhelan pwhelan temporarily deployed to pr October 4, 2023 13:25 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 4, 2023 13:25 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 4, 2023 13:25 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 4, 2023 13:55 — with GitHub Actions Inactive
@pwhelan pwhelan force-pushed the pwhelan-fleet-windows-mkdir branch from 92c2cd0 to a212c5e Compare October 12, 2023 21:49
@pwhelan pwhelan temporarily deployed to pr October 12, 2023 21:50 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 12, 2023 21:50 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 12, 2023 21:50 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 12, 2023 22:17 — with GitHub Actions Inactive
@pwhelan pwhelan force-pushed the pwhelan-fleet-windows-mkdir branch from a212c5e to 06150e7 Compare October 23, 2023 19:12
@pwhelan pwhelan temporarily deployed to pr October 23, 2023 19:13 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 23, 2023 19:13 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 23, 2023 19:13 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 23, 2023 19:44 — with GitHub Actions Inactive
@edsiper edsiper merged commit c95938b into master Nov 7, 2023
42 checks passed
@edsiper edsiper deleted the pwhelan-fleet-windows-mkdir branch November 7, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants